fix: bedrock creds refresh by michaelneale · Pull Request #5599 · block/goose

michaelneale · 2025-11-06T05:31:28Z

a speculative fix for: #5132

hopefully by loading each time it won't be stale, but not sure of this approach as don't currently have bedrock access or familiarity.

Copilot

Pull Request Overview

This PR refactors the BedrockProvider to remove cached AWS client state and instead create a fresh client on every API call. The changes address potential credential expiry issues by ensuring credentials are re-loaded from the environment for each request.

Removed the client field from BedrockProvider struct
Moved AWS client creation from initialization to the converse method
Updated initialization to only validate credentials without storing the client

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-06T05:32:55Z

crates/goose/src/providers/bedrock.rs

+        let sdk_config = aws_config::load_from_env().await;
+        let client = Client::new(&sdk_config);


Creating a new AWS SDK config and client on every API call introduces significant overhead. The aws_config::load_from_env() call performs I/O operations to load credentials from various sources (environment variables, config files, instance metadata, etc.). Consider implementing a caching mechanism with credential refresh logic, or leverage the AWS SDK's built-in credential provider caching to avoid this repeated overhead on each request.

this seems like a fair point although depends on how much overhead - making an LLM call is expensive so maybe it doesn't matter?

yeah - that was the slop comment left by goose (and copilot is just parrotting the same). I don't really know, but I don't trust this aws stuff very much and if it isn't practically that slow... it may be ok. but does seem extreme (mostly I wanted to see if someone could try it out and see if it worked in the first case). Another option is to somehow trap and re-initialise when needed.

DOsinga · 2025-11-06T14:07:45Z

crates/goose/src/providers/bedrock.rs

        set_aws_env_vars(config.all_values());
        set_aws_env_vars(config.all_secrets());

+        // Validate credentials at initialization time by loading config and checking credentials


this comment does not help me. adding a targeting comment to 67 saying .provide_redentials() throws an error on invalid credentials maybe?

DOsinga · 2025-11-06T14:08:42Z

crates/goose/src/providers/bedrock.rs

+        let sdk_config = aws_config::load_from_env().await;
+        let client = Client::new(&sdk_config);


this seems like a fair point although depends on how much overhead - making an LLM call is expensive so maybe it doesn't matter?

Removed comment about validating credentials during initialization.

Copilot

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/goose/src/providers/bedrock.rs

* main: (33 commits) Fix Claude Code provider to default to Auto mode (#5638) (#5642) Scheduler cleanup (#5571) Better search paths and handling of CLI providers (#5554) docs: description required for "Add Extension" in cli - phase 2 (#5635) Remove some logging (#5631) Use session IDs as task IDs for subagents instead of UUIDs (#5398) Fix the naming (#5628) fix: default tetrate model is broken, replace with haiku-4.5 (#5535) (#5587) Fetch less and use the right SHA (#5621) feat(ui): add custom macOS dock menu with New Window option (#5099) feat: remove hints from recipe prompts (#5622) docs: October 2025 Community All-Stars spotlight, Hacktoberfest edition (#5625) differentiate debug/release in cache key (#5613) Unify subrecipe and subagent execution through shared recipe pipeline (#5082) Standardize CLI argument flags and update documentation (#5516) Release 1.13.0 fix: move goosehints/AGENTS.md handling to goose, and out of developer extension (#5575) fix: add standard context menu items to prevent empty right-click menu (#5616) Bump openapi in prepare-release (#5611) docs: add access control section to Developer tutorial (#5615) ...

Copilot

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

michaelneale · 2025-11-10T07:10:25Z

ok, tested this with timeout with my setup (and refreshing) and it works.

* main: (83 commits) silence copilot on minor text issues (block#5665) fix: disallow runaway subagent chains (block#5659) chore: remove usage of non-existent env var for log dir (block#5658) clarify agent instructions (block#5655) feat: add check-everything for unified style checks (block#5650) Show errors on failure (block#5643) custom instructions for copilot reviews (block#5646) fix: prevent repeated 404 errors when accessing deleted sessions (block#5644) Flake.nix corrected main (block#5600) fix: goose recipe list can return duplicated entries (block#5645) fix: bedrock creds refresh (block#5599) Fix Claude Code provider to default to Auto mode (block#5638) (block#5642) Scheduler cleanup (block#5571) Better search paths and handling of CLI providers (block#5554) docs: description required for "Add Extension" in cli - phase 2 (block#5635) Remove some logging (block#5631) Use session IDs as task IDs for subagents instead of UUIDs (block#5398) Fix the naming (block#5628) fix: default tetrate model is broken, replace with haiku-4.5 (block#5535) (block#5587) Fetch less and use the right SHA (block#5621) ...

* main: silence copilot on minor text issues (#5665) fix: disallow runaway subagent chains (#5659) chore: remove usage of non-existent env var for log dir (#5658) clarify agent instructions (#5655) feat: add check-everything for unified style checks (#5650) Show errors on failure (#5643) custom instructions for copilot reviews (#5646) fix: prevent repeated 404 errors when accessing deleted sessions (#5644) Flake.nix corrected main (#5600) fix: goose recipe list can return duplicated entries (#5645) fix: bedrock creds refresh (#5599)

Signed-off-by: Blair Allan <Blairallan@icloud.com>

load creds more often

ee17cc4

Copilot AI review requested due to automatic review settings November 6, 2025 05:31

Copilot AI reviewed Nov 6, 2025

View reviewed changes

michaelneale mentioned this pull request Nov 6, 2025

AWS Bedrock Token Refresh Issue - Goose Not Reading Updated Credentials #5132

Closed

DOsinga approved these changes Nov 6, 2025

View reviewed changes

slop that slipped through

ff21d8e

Removed comment about validating credentials during initialization.

Copilot AI review requested due to automatic review settings November 7, 2025 01:19

Copilot AI reviewed Nov 7, 2025

View reviewed changes

crates/goose/src/providers/bedrock.rs Show resolved Hide resolved

michaelneale added 2 commits November 10, 2025 16:32

add us prefixes

f493553

Copilot AI review requested due to automatic review settings November 10, 2025 06:20

Copilot AI reviewed Nov 10, 2025

View reviewed changes

michaelneale merged commit 743dc2a into main Nov 10, 2025
22 checks passed

github-actions bot mentioned this pull request Nov 11, 2025

chore(release): release version 1.14.0 (minor) #5676

Merged

Surendhar-N-D pushed a commit to Surendhar-N-D/goose that referenced this pull request Nov 17, 2025

fix: bedrock creds refresh (block#5599)

2fb665c

arul-cc pushed a commit to arul-cc/goose that referenced this pull request Nov 17, 2025

fix: bedrock creds refresh (block#5599)

073f029

BlairAllan pushed a commit to BlairAllan/goose that referenced this pull request Nov 29, 2025

fix: bedrock creds refresh (block#5599)

1f588a2

Signed-off-by: Blair Allan <Blairallan@icloud.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: bedrock creds refresh#5599

fix: bedrock creds refresh#5599
michaelneale merged 4 commits intomainfrom
micn/bedrock-refresh

michaelneale commented Nov 6, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 6, 2025

Uh oh!

DOsinga Nov 6, 2025

Uh oh!

michaelneale Nov 7, 2025

Uh oh!

DOsinga Nov 6, 2025

Uh oh!

DOsinga Nov 6, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

michaelneale commented Nov 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		let sdk_config = aws_config::load_from_env().await;
		let client = Client::new(&sdk_config);

Conversation

michaelneale commented Nov 6, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

DOsinga Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

michaelneale Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

DOsinga Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

DOsinga Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

michaelneale commented Nov 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants